Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication): passwordless login #346

Merged
merged 27 commits into from
Oct 3, 2022
Merged

feat(authentication): passwordless login #346

merged 27 commits into from
Oct 3, 2022

Conversation

SotiriaSte
Copy link
Contributor

@SotiriaSte SotiriaSte commented Sep 23, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@SotiriaSte SotiriaSte marked this pull request as draft September 23, 2022 14:28
@SotiriaSte
feat(authentication): verify passwordless login endpoint WIP
8204521
@SotiriaSte
Merge branch 'main' of https://github.com/ConduitPlatform/Conduit int…
65fb2f4 
…o implement-passwordless-login
@SotiriaSte
feat(authentication): passwordlessLogin email template
96cfb72
@SotiriaSte
fix(authentication): or query
d2fccec
@SotiriaSte
fix(authentication): minor fixes
a053031
@SotiriaSte
fix(authentication): verify passwordless login function
db2da99
@SotiriaSte
fix(authentication): removed phone param and logic from passwordless-…
4a5f5bd 
…login
@SotiriaSte
fix(authentication): merge main
be23cde
@SotiriaSte
fix(authentication): passwordless login rename
bf24501
@SotiriaSte
Merge branch 'main' of https://github.com/ConduitPlatform/Conduit int…
59906cf 
…o implement-passwordless-login
@SotiriaSte
Merge branch 'main' of https://github.com/ConduitPlatform/Conduit int…
15e4444 
…o implement-passwordless-login

� Conflicts:
�	modules/authentication/src/config/config.ts
�	modules/authentication/src/handlers/local.ts
@SotiriaSte
feat(authentication): magiclink handler WIP
cd4a757
@SotiriaSte
fix(authentication): naming
985b84e
@SotiriaSte
Merge branch 'main' of https://github.com/ConduitPlatform/Conduit int…
fda9417 
…o implement-passwordless-login
@SotiriaSte
feat(authentication): magic link handler NOT tested
ad6838f
@SotiriaSte
feat(authentication): magic link handler
e9f8656
@SotiriaSte
Merge branch 'main' of https://github.com/ConduitPlatform/Conduit int…
9905eb8 
…o implement-passwordless-login

� Conflicts:
�	modules/authentication/src/constants/TokenType.ts
@SotiriaSte SotiriaSte marked this pull request as ready for review October 3, 2022 11:56
kon14
kon14 previously requested changes Oct 3, 2022
View reviewed changes
modules/authentication/src/config/index.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
@SotiriaSte SotiriaSte requested a review from kon14 October 3, 2022 13:17
kkopanidis
kkopanidis requested changes Oct 3, 2022
View reviewed changes
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/magic.link.ts Outdated Show resolved Hide resolved
@kkopanidis kkopanidis dismissed kon14’s stale review October 3, 2022 14:00

no longer applies

@kkopanidis kkopanidis merged commit 7c9df4b into main Oct 3, 2022
@kkopanidis kkopanidis deleted the implement-passwordless-login branch October 3, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkopanidis kkopanidis kkopanidis approved these changes

@kon14 kon14 Awaiting requested review from kon14

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SotiriaSte @kon14 @kkopanidis