refactor(authentication)!: major code cleanup #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(authentication)!: split cookie options to global and token-specific refactor(authentication)!: merge token expire in access and refresh tokens refactor(authentication)!: expand refresh token availability refactor(authentication)!: allow access/refresh tokens to be set as cookies separately refactor(authentication): centralized token provisioning to cleanup code
fix(authentication): multi-session checks now applied in all providers
fix(authentication): multi-session checks now applied in all providers chore(authentication): cleanup imports
…t actual model refactor(authentication)!: re-work 2fa mechanics to utilize JWT feat(authentication)!: add sudo mode to JWT to protect sensitive operations
kkopanidis
force-pushed
the
auth-refactor
branch
from
b193a84
to
be897ce
Compare
kon14
requested changes
Sep 28, 2022
kon14
force-pushed
the
auth-refactor
branch
from
8f81559
to
2739fbe
Compare
kon14
force-pushed
the
auth-refactor
branch
from
52b7f64
to
0bd1374
Compare
|
Rebased against |
feat(grpc-sdk): implement config override chore(authentication): remove empty file refactor(authentication): fix schema migration
kon14
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a major cleanup in Authentication:
accessTokencookiesBREAKING CHANGE:
refreshTokencookie.userId(string) ->user(relation)What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: