feat(grpc-sdk): service address url remapping for host/docker interoperability #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erability This should facilitiate development of Conduit modules on the host, while making use of a locally deployed container-based Conduit instance. Spin up a dockerized Conduit deployment, then start your microservice with the following env vars: SERVICE_URL: host.docker.internal:XXXXX (specifying an available port) URL_REMAP: 0.0.0.0 Notes: - container gRPC service ports should be exposed - Linux systems need: --add-host=host.docker.internal:host-gateway - Remote deployments are not supported
kkopanidis
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should facilitiate development of Conduit modules on the host, while making use of a locally deployed container-based Conduit instance.
Spin up a dockerized Conduit deployment, then start your microservice with the following env vars:
SERVICE_URL: host.docker.internal:XXXXX (specifying an available port)URL_REMAP: 0.0.0.0Notes:
I've updated the compose file so that it includes the solution for Linux users.
I kept the service port exports commented out so as not keep failure points to a minimum for the vast majority of users.
I also updated all the port related envs to match internal/external ports (as we only update the address part).
Ideally, I'll handle optionally exposing the ports through the CLI using a single compose file.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: