Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc-sdk,hermes,admin,router): request params split #446

Merged
merged 7 commits into from
Nov 25, 2022

Conversation

SotiriaSte
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@SotiriaSte SotiriaSte marked this pull request as draft November 23, 2022 16:29
@SotiriaSte SotiriaSte marked this pull request as ready for review November 24, 2022 08:35
@kon14 kon14 changed the title Params split feat(grpc-sdk,hermes,admin,router): request params split Nov 24, 2022
@SotiriaSte SotiriaSte marked this pull request as draft November 24, 2022 11:49
@SotiriaSte SotiriaSte marked this pull request as ready for review November 24, 2022 16:56
@kkopanidis kkopanidis merged commit 70dcc7b into main Nov 25, 2022
@kkopanidis kkopanidis deleted the params-split branch November 25, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants