Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get-conduit.sh not being POSIX compatible #485

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Jan 11, 2023

This PR updates get-conduit.sh to be POSIX compatible.
It still only adds the CLI to the executable $PATH for bash and zsh, but the script itself is more portable.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number

@kon14 kon14 requested a review from kkopanidis January 11, 2023 09:27
@kon14 kon14 marked this pull request as ready for review January 11, 2023 10:15
@kkopanidis kkopanidis merged commit d3f638e into main Jan 11, 2023
@kkopanidis kkopanidis deleted the posix-installer-script branch January 11, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants