Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ManagedModule Refactor for Forms #52

Merged
merged 2 commits into from
Feb 24, 2022
Merged

ManagedModule Refactor for Forms #52

merged 2 commits into from
Feb 24, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Feb 24, 2022

Followup of #44.

Also fixes GetFormReplies expecting form id as a query param.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

GetFormReplies now properly accepts form id as a url param.

The PR fulfills these requirements:

  • It's submitted to the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx, where "xxx" is the issue number)

BREAKING CHANGE:
GetFormReplies now properly accepts form id as a url param
@kon14 kon14 changed the title Managed refactor forms ManagedModule Refactor for Forms Feb 24, 2022
@kkopanidis kkopanidis merged commit 2d9777f into main Feb 24, 2022
@kkopanidis kkopanidis deleted the managed-refactor-forms branch February 24, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants