Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cms db merge #53

Merged
merged 6 commits into from
Feb 25, 2022
Merged

Cms db merge #53

merged 6 commits into from
Feb 25, 2022

Conversation

kkopanidis
Copy link
Contributor

@kkopanidis kkopanidis commented Feb 24, 2022

Will close #22 and #51.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

BREAKING CHANGE:

  • All /admin/cms/* routes are now available under /database/cms
  • [GET] /admin/database/schemas/extensions return definition change
    'declaredSchemaExtensions' -> 'schemaExtensions'

The PR fulfills these requirements:

  • It's submitted to the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

add(database): owner migration to move CMS schemas to database
add(database): query types to better specify query requirements
add(database): conditional query parsing
refactor(database,grpc-sdk): use ManagedModule
fix(database): deleteSchemas system schema deletion check failing

BREAKING CHANGE:
- All /admin/cms/* routes are now available under /database/cms
- [GET] /admin/database/schemas/extensions return definition change
  'declaredSchemaExtensions' -> 'schemaExtensions'
@kon14 kon14 self-requested a review February 25, 2022 15:46
@kon14 kon14 marked this pull request as ready for review February 25, 2022 15:46
@kon14
Copy link
Contributor

kon14 commented Feb 25, 2022

Sneaked in a new route, addressing #51, while at it.

@kkopanidis kkopanidis changed the title [WIP] Cms db merge Cms db merge Feb 25, 2022
@kkopanidis kkopanidis merged commit f5b054b into main Feb 25, 2022
@kkopanidis kkopanidis deleted the cms-db-merge branch February 25, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Merge CMS with Database
2 participants