Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplication, ts-ignore, any types #533

Merged
merged 10 commits into from
Feb 23, 2023
Merged

Conversation

SotiriaSte
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

@SotiriaSte SotiriaSte marked this pull request as draft February 21, 2023 16:03
@SotiriaSte SotiriaSte marked this pull request as ready for review February 22, 2023 14:37
@SotiriaSte SotiriaSte requested review from kon14 and kkopanidis and removed request for kon14 February 22, 2023 14:37
…o general-codefactor-issues

# Conflicts:
#	modules/database/src/adapters/DatabaseAdapter.ts
modules/database/src/adapters/DatabaseAdapter.ts Outdated Show resolved Hide resolved
libraries/hermes/src/Rest/SwaggerParser.ts Show resolved Hide resolved
libraries/hermes/src/Rest/SwaggerParser.ts Outdated Show resolved Hide resolved
@kkopanidis kkopanidis merged commit 465b35e into main Feb 23, 2023
@kkopanidis kkopanidis deleted the general-codefactor-issues branch February 23, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants