fix(authentication): provider email/id matching not working properly #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…only behaviour feat(module-tools): new module to handle module-specific operations
refactor(module-tools): rework ModuleManager, ManagedModule to a combined class
refactor(module-tools): move metrics property to grpc-sdk
fix(hermes): typing issue
…authorization header
chore(authorization): optimize imports & cleanup code
chore(database): optimize imports & cleanup code
chore(forms): optimize imports & cleanup code
chore(functions): optimize imports & cleanup code
chore(push-notifications): optimize imports & cleanup code
chore(router): optimize imports & cleanup code
chore(sms): optimize imports & cleanup code
chore(storage): optimize imports & cleanup code
chore(commons): optimize imports & cleanup code
refactor(module-tools): use correct MetricType in metrics
# Conflicts: # modules/authentication/src/handlers/oauth2/apple/apple.ts # modules/storage/src/Storage.ts
fix(module-tools): duplicate grpcSdk set fix(module-tools): initial module health triggering before start
refactor(module-tools): add module.proto for setConfig requests refactor: remove setConfig requests from modules refactor: remove custom Empty message type and replace with google's refactor(core): change updateRequest/generateProto requests/types conflict with router/database
refactor(grpc-sdk): remove forms/functions empty services feat(grpc-sdk): assign ConduitModuleDefinition to unknown registered modules feat(module-tools): initialize modules with at least health and ConduitModuleDefinition refactor(storage): remove empty import
kon14
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: