fix(storage): updateFile handler storing undefined filename when no name param provided and folder param workaround #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame param provided fix(storage): updateFile not recognizing folder names sans / suffix
chore(storage): clean up getFileUrl redirect check
kkopanidis
pushed a commit
that referenced
this pull request
Mar 14, 2022
* fix(storage): updateFile handler storing undefined filename when no name param provided fix(storage): updateFile not recognizing folder names sans / suffix * fix(storage): updateFile fixes chore(storage): clean up getFileUrl redirect check
kkopanidis
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes updateFile saving File.name as undefined on requests where name param is not provided.
Fixes folder names requiring a slash suffix (pain-free workraound).
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)