Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): missing check for double removal of unresponsive module #850

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

kkopanidis
Copy link
Contributor

refactor(core): add sanity check for module existence in monitor loop

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

refactor(core): add sanity check for module existence in monitor loop
@kkopanidis kkopanidis merged commit 74ba6d5 into main Dec 18, 2023
5 checks passed
@kkopanidis kkopanidis deleted the core/service-monitor branch December 18, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants