Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Redundant REST router refreshes #89

Closed
kon14 opened this issue Mar 22, 2022 · 0 comments · Fixed by #90
Closed

[BUG] Redundant REST router refreshes #89

kon14 opened this issue Mar 22, 2022 · 0 comments · Fixed by #90
Assignees
@kon14
Labels
bug Something isn't working

Comments

@kon14
Copy link
Contributor

kon14 commented Mar 22, 2022

Describe the bug
REST router currently refreshes excessively due to refreshRouter() directly refreshing the Express router instead of scheduling a refresh based on a timeout, much like registerRoute() and registerConduitRoute() already do.

To Reproduce

  1. Set a breakpoint in REST controller's refreshRouter()
  2. Debug Core by itself
  3. Notice excessive refreshes

N of refresh calls would differ based on previously registered routes, but on a fresh Redis state it should be 1.

Expected behavior
refreshRouter() should schedule a router refresh instead of directly refreshing Express.
@kon14 kon14 self-assigned this Mar 22, 2022
@kon14 kon14 added the bug Something isn't working label Mar 22, 2022
@kon14 kon14 mentioned this issue Mar 22, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kon14 kon14

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router): excessive REST router refreshes ConduitPlatform/Conduit
1 participant
@kon14