Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in the simulation code #2

Open
Emrys365 opened this issue Jan 29, 2021 · 4 comments
Open

Bugs in the simulation code #2

Emrys365 opened this issue Jan 29, 2021 · 4 comments

Comments

@Emrys365
Copy link

Emrys365 commented Jan 29, 2021

I notice that the simulation code is not compatible with the current pyrirgen.

In tencent_challenge_rirgenerator.py#L75, it calls the function pyrirgen.generateRir, but this API has been refactored to pyrirgen.rir_generator since this commit in phecda-xu/RIR-Generator

Could you update it and also double-check the scripts?

@Emrys365
Copy link
Author

I found the reason. I installed pyrirgen by following the link recommended in https://github.com/ConferencingSpeech/ConferencingSpeech2021/blob/master/ReadMe.md#requirements.
But the simulation code is not built based on the latest version of https://github.com/phecda-xu/RIR-Generator.
So the solution is to directly use the compiled library pyrirgen.cpython-37m-x86_64-linux-gnu.so:

cd simulation
python tencent_challenge_rirgenerator.py

@shincling
Copy link

I also found it Wangyou @Emrys365 . But I directly install the pyrirgen from the https://github.com/Marvin182/rir-generator, which solved it.

@jacktong1989
Copy link

I found the reason. I installed pyrirgen by following the link recommended in https://github.com/ConferencingSpeech/ConferencingSpeech2021/blob/master/ReadMe.md#requirements.
But the simulation code is not built based on the latest version of https://github.com/phecda-xu/RIR-Generator.
So the solution is to directly use the compiled library pyrirgen.cpython-37m-x86_64-linux-gnu.so:

cd simulation
python tencent_challenge_rirgenerator.py

May I ask how to use the compiled library "pyrirgen.cpython-37m-x86_64-linux-gnu.so"? Thanks in advance.

@Emrys365
Copy link
Author

May I ask how to use the compiled library "pyrirgen.cpython-37m-x86_64-linux-gnu.so"? Thanks in advance.

Sorry for my late reply. I remember it was simply:

Just add the directory of pyrirgen.cpython-37m-x86_64-linux-gnu.so to $PATH

export LD_LIBRARY_PATH="/path/to/ConferencingSpeech2021/simulation":$LD_LIBRARY_PATH
cd "/path/to/ConferencingSpeech2021/simulation"
python ./challenge_rirgenerator.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants