New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Texture updates broken #109
Comments
After I fixed the above issue on my local TF build, I've encountered another issue related texture updates/creation with DX12 specifically. If you create an empty texture by setting the pDesc on the TextureLoadDesc, this line will overwrite the start state on the description with either a SRV/UAV state:
updateTexture() then fails as the copy queue can not do auto-promotion from that state to COPY_DEST. All other texture creation methods seem to leave the newly created texture in either the COPY_DEST or COMMON state so updateTexture() calls work. Maybe this is all intended behaviour though - I've worked around it by either first transitioning the state on the graphics queue first or removing this line that overwrites the start state. |
@jdswebb Did we actually fix this? Please close in case we did .. |
It doesn't look like anything changed that would fix this browsing the source. I'm not using updateTexture any more so I can't verify that for sure without making a new repro case. |
is fixed now. |
See:
https://github.com/ConfettiFX/The-Forge/blob/master/Common_3/Renderer/ResourceLoader.cpp#L1022
pImage is created but never assigned to the update description.
The text was updated successfully, but these errors were encountered: