Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resizing images to 256x256 #8

Closed
kunhe opened this issue Oct 2, 2019 · 2 comments
Closed

resizing images to 256x256 #8

kunhe opened this issue Oct 2, 2019 · 2 comments

Comments

@kunhe
Copy link

kunhe commented Oct 2, 2019

transf_list.extend([transforms.RandomResizedCrop(size=224) if opt.arch=='resnet50' else transforms.RandomResizedCrop(size=227),

I believe there's a bug in BaseTripletDataset.transform: during training, images are not resized to 256x256 before taking crops.

Interestingly, this did not seem to affect results by much, at least when I tested it in Online Products with Margin loss...

@bbrattoli
Copy link
Collaborator

Thank you for your comment.

I believe that this was by choice. Not normalizing to 256 helps as an extra augmentation.

Nevertheless, thank you for letting us know that it does not change the result much.

@kunhe
Copy link
Author

kunhe commented Oct 2, 2019

That's good to know, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants