This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
Fix call stack when a Doctrine proxy subclass is active #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine proxy classes change the call stack due to also overloading the aliased trait methods.
This changes the stack to:
setSomefileUpload->setFileUpload->getFileUploadPropertyNameWhere it normally would be:
setSomefileUpload->getFileUploadPropertyNameThis PR fixes the difference, which makes sure that the file upload property name can be determined both with a 'normal' Doctrine entity class and a Doctrine proxy class.
Already tested and implemented in FlexModel/FlexModelBundle#57 and FlexModel/FlexModelBundle#58.