Fixes Android install errors (eg. Cannot find module internal/util/types) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes ConnectSDK#77 Fixes "Error: Cannot find module internal/util/types" and Fixes "Failed to install 'cordova-plugin-connectsdk': Error: Cannot find module 'setimmediate'"
|
Basically, the required node_modules were committed to the repo and were not dynamically retrieved by npm before install. So removing the hard-coded node_modules and adding them to the dependencies seems to have worked. (I'm thinking the hard-coded node_modules worked with a specific version of Cordova which included the node_modules' dependencies as part of the platform but have since been removed or changed.) |
Lindsay-Needs-Sleep
changed the title
|
I believe this will also fix #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modules should not be committed. Instead add them as a dependency.
This fixes #77
Fixes "Error: Cannot find module internal/util/types"
and Fixes "Failed to install 'cordova-plugin-connectsdk': Error: Cannot find module 'setimmediate'"