Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add define('WP_SCSS_ALWAYS_RECOMPILE', true); to settings page #151

Closed
bick opened this issue Jan 18, 2021 · 6 comments · Fixed by #162
Closed

[Feature Request] Add define('WP_SCSS_ALWAYS_RECOMPILE', true); to settings page #151

bick opened this issue Jan 18, 2021 · 6 comments · Fixed by #162
Assignees

Comments

@bick
Copy link

bick commented Jan 18, 2021

I had this idea when I was installing the plugin for the millionth time on a site, I always have to google the define('WP_SCSS_ALWAYS_RECOMPILE', true); code because I don't have it written down anywhere. It'd be very convenient if on the settings page, it was written at the bottom or something. I have to use it with pretty much all dev sites.

Thanks

@shadoath
Copy link
Collaborator

@bick When you reference the Settings page can you be more specific? Do you want it in the readme of this repo or on the WP plugin page?

@zachary-cameron
Copy link

I'll just jump in here for my 2 cents -- I think @bick meant the WP plugin settings page. We have a similar workflow for our dev sites, and it's a pain to remember to enable the WP_SCSS_ALWAYS_RECOMPILE flag, and to disable it when we go live. It would be easier to simply have a checkbox for "Always recompile SCSS" in the WP plugin settings page.

@bick
Copy link
Author

bick commented Feb 8, 2021

Yeah, @shadoath I meant the plugin settings page. Having it be there as a text snippet that you can simply copy and paste would be perfect, but @aerothopter's suggestion would be even more convenient.

@shadoath
Copy link
Collaborator

shadoath commented Feb 9, 2021

@bick @aerothopter please take a look at #162. Currently this allows for both options. I'm thinking it could be improved if it showed if the WP_SCSS_ALWAYS_RECOMPILE flag was defined in the settings page.

@zachary-cameron
Copy link

I agree. From a UX perspective, if the WP_SCSS_ALWAYS_RECOMPILE flag was defined, then the checkbox would be disabled (i.e. locked to enabled/disabled) with a tooltip letting the user know that the setting is locked using the WP_SCSS_ALWAYS_RECOMPILE flag. And if it were not defined, the user would be able to use the checkbox as normal.

@shadoath
Copy link
Collaborator

Screen Shot 2021-02-12 at 17 20 35

I think this feature is ready.

@shadoath shadoath self-assigned this Feb 13, 2021
@shadoath shadoath linked a pull request Feb 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants