Test updates #467
Merged
Test updates #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test would pass on a system that has the DTD files installed, but most developers don't have that. Rather than having the developer chase her/his tail, just skip it. Besides, the conversion from 0.5 to 0.7 took place over 2yrs ago.
This could be a difference between PostgreSQL 9.4 and 9.6.
PostgreSQL >=9.5 prints out the location where the error occured. These changes check for the specific message and ignore the details around it.
The tests were failing due to webob and pyramid>=1.8 allowing @ and : as safe elements in a url. This should be backwards compatible as well.
reedstrm
reviewed
Jan 25, 2017
reedstrm
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to bring the tests up-to-date (now using pyramid>=1.8).
I've made a small executive decision to skip the entity expansion test altogether. The DTD files are no longer available at the defined url. We've fixed this several times over the past few years and it just keeps popping up. For the most part this is no longer relevant since we've converted cnxml 0.5 to cnxml 0.7 in production. Furthermore, production machines are natively loaded with the DTD files. Also, if we for some reason legitimately run into this on production, it would fail fast and loud during an operation that is not user facing.
I've added one feature to skip tests that require memcached when memcached is not running. This is particularly useful for those that aren't testing that part of the system. A warning message is posted on test run; so it's not a silent operation.