Persists user information during role entry and publication requests #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should cover cases with missing roles as well as third-party.
mmulich
force-pushed
the
shadow-casting
branch
from
302763a
to
964fb66
Compare
|
Looks like a release of openstax-accounts is going to be required. |
|
The coverage is not going to pass anytime soon. I'm managed to scope the coverage report, but that has brought down the coverage by nearly 2%. The good thing is that it is now more accurate. |
|
|
||
| # Update existing records. | ||
| for user_id in existing_user_ids: | ||
| # TODO only update based on a delta against the 'updated' column. |
There was a problem hiding this comment.
doesn't really save anything: postgresql will need to form an entire new tuple anyway, and the data here is so small not sending the unchanged values isn't worth it. Simple is better. So, no TODO
reedstrm
added a commit
that referenced
this pull request
Feb 18, 2015
Persists user information during role entry and publication requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on openstax/openstax-accounts#16 & openstax/cnx-archive#290
See also trello card