Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a moderation interface #90

Merged
merged 5 commits into from
Mar 16, 2015
Merged

Add a moderation interface #90

merged 5 commits into from
Mar 16, 2015

Conversation

mmulich
Copy link
Contributor

@mmulich mmulich commented Mar 11, 2015

See also sprint 37 card.

This completes the interface and functionality for accepting/rejecting publications for first time publishers.

This state is entered when the user has not previously been
moderated or vetted by another user. The vetting process is peer
based.
It is possible to not be vetted and still be allowed to make
a revision publication. This is a secondary form of vetting,
which trusts the publishing application/party.
@mmulich
Copy link
Contributor Author

mmulich commented Mar 11, 2015

ALTER TABLE publications
    ADD COLUMN created TIMESTAMP WITH TIME ZONE DEFAULT CURRENT_TIMESTAMP,
ALTER TABLE publications
    ALTER COLUMN epub DROP NOT NULL;

ALTER TYPE publication_states
    ADD VALUE 'Waiting for moderation' AFTER 'Failed/Error';
ALTER TYPE publication_states
    ADD VALUE 'Rejected' AFTER 'Waiting for moderation';

BTW, pyrseas didn't notice the type alternations, nor the dropped constraint.

@mmulich
Copy link
Contributor Author

mmulich commented Mar 11, 2015

Depends on openstax/cnx-archive#302

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3fd08f3 on moderation into * on master*.

@rich-hart rich-hart self-assigned this Mar 13, 2015
@reedstrm
Copy link
Contributor

Drying out the cursor is good: I think it's on the way to making a publish event more transactional.

@reedstrm
Copy link
Contributor

Confirmed on Pyrseas 7.1 missing the enum diff and the drop of null constraint.

reedstrm added a commit that referenced this pull request Mar 16, 2015
@reedstrm reedstrm merged commit 7b7817f into master Mar 16, 2015
@mmulich
Copy link
Contributor Author

mmulich commented Mar 16, 2015

Yeah, I'm not sure how I feel about what I did here. You'll notice that it does some fancy argument things. It may cause not be future proof, but then again, what really is?

@reedstrm reedstrm deleted the moderation branch March 16, 2015 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants