Use global tag for logging to start #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderbiscuit
force-pushed
the
fix/small-nits
branch
from
cd69e24
to
ee63d24
Compare
thunderbiscuit
force-pushed
the
fix/small-nits
branch
from
ee63d24
to
371578e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially had written a few of the logging lines in a more traditional way with a specific tag for each file/class, but I'm now changing my tune; I think for now it makes sense to have more like a global tag to start, and maybe customize if or when it's required for specific logging entries.
This PR simply creates a global default tag I called
LDKTAG(not sure about the name but I needed something), and switches all log entries in the current app to use that tag. This makes it very easy to follow all tags emitted by us. I also fixed a small bug I introduced in the previous refactoring (capitalization of thegetLatestBlockHash()method).