Skip to content
This repository has been archived by the owner on Jun 14, 2018. It is now read-only.

don't synchronzie constant function, closes #4 #6

Closed
wants to merge 1 commit into from

Conversation

mhhf
Copy link

@mhhf mhhf commented Aug 25, 2015

Constant functions don't change the state and arn't executing a
transaction, therefore they don't need to be synchronized.

Constant functions don't change the state and arn't executing a
transaction, therefore they don't need to be synchronized.
@tcoulter
Copy link
Contributor

@mhhf This sounds like a good change. Can you give me corresponding contract code and Javascript code where this causes an issue, just so I can experience the problem that this fixes? Thanks!

@mhhf
Copy link
Author

mhhf commented Aug 25, 2015

@tcoulter: here you go: https://github.com/mhhf/pudding_minierror

truffle deploy
truffle build
python -m SimpleHTTPServer 8000

@tcoulter
Copy link
Contributor

Thanks! I made a comment on the other ticket that you should be using instance.query.call(). However, this change may still be a good one. Let me look into it more. Thanks for the great example!

@tcoulter
Copy link
Contributor

Fixed as of latest commit! I refactored everything, so couldn't include your PR, but thanks for the help!

@tcoulter tcoulter closed this Oct 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants