This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Upgrade signers to 1.0.19 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes vertx upgrade and transitive azure key vault upgrade with breaking change to SECP256K1 curve.
siladu
commented
Sep 24, 2021
CHANGELOG.md
Outdated
| - Add validation for GoQuorum transactions with value https://github.com/ConsenSys/ethsigner/pull/377 | ||
| - Upgrade web3j to latest version for fix to handle large chainids in eip155 transactions https://github.com/ConsenSys/ethsigner/pull/382 | ||
| - Add publishing to docker namespace "consensys/ethsigner" and deprecate docker namespace "consensys/quorum-ethsigner" https://github.com/ConsenSys/ethsigner/issues/384 | ||
| - Upgrade to signers 1.0.19 allows empty password files to be read when creating a Signer https://github.com/ConsenSys/ethsigner/issues/372 |
There was a problem hiding this comment.
@usmansaleem Should this be under "Bugs Fixed"?
siladu
commented
Sep 24, 2021
CHANGELOG.md
Outdated
| - Add publishing to docker namespace "consensys/ethsigner" | ||
| - Deprecating docker namespace "consensys/quorum-ethsigner" | ||
| - Add validation for GoQuorum transactions with value https://github.com/ConsenSys/ethsigner/pull/377 | ||
| - Upgrade web3j to latest version for fix to handle large chainids in eip155 transactions https://github.com/ConsenSys/ethsigner/pull/382 |
There was a problem hiding this comment.
@usmansaleem Should this be under "Bugs Fixed"?
siladu
commented
Sep 24, 2021
| @@ -1,11 +1,14 @@ | |||
| # Changelog | |||
|
|
|||
| ## ...Next Version... | |||
There was a problem hiding this comment.
@usmansaleem Any suggestions for the next version number?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes vertx upgrade and transitive azure key vault upgrade with breaking change to SECP256K1 curve.
Allows empty password files to be read.
Fixes #372