Clean up MulByXXX methods, hard-coded non-residue constants in the template generator #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plate fpInlineMulByNonResidue, clean up generated comments
…template fpInlineMulByNonResidueInv, more comment cleaning
…plate fp2InlineMulByNonResidue
…template fp2InlineMulByNonResidueInv, clean up some dollar signs
…plate fp6InlineMulByNonResidue
…good thing no one called this code; good thing we had tests... :rolleyes:
…o to pairing.go, delete MulByV2NRInv, MulByNWNRInv, MulByWNRInv
…r, regenerate code to ensure it's correct
…k commit 7dcd496ba42799bf1d4b695226ce6cc4c1f48792
…ly into mulAssign, add some comments
…dueInv methods; inline them instead
… detection in the future
…s for MulByNonResidue
…ByNonResidueInv helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7 , #8 .
All the hard-coded constants mentioned in #8 appear only in the MulByXXX methods in
pairing.gofor each curve. It was decided that pairing code will not be generated from template (see #9 ). As such, I've simply removed code for generatingtwoInvfrom the template generator.