Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field: add SetInt64 and support for uint8 uint16 ... etc in SetInterface #111

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Dec 10, 2021

No description provided.

@gbotrel gbotrel requested a review from Tabaie December 10, 2021 20:31
Copy link
Contributor

@Tabaie Tabaie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's just that one redundant import

@@ -7,12 +7,14 @@ import (
"encoding/json"
"math/big"
"math/bits"
"fmt"
{{if .NoCarry}} mrand "math/rand" {{end}}
"testing"
{{if .UseAddChain}} "fmt" {{ end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can take this out now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope it is used in the added tests 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm referring to line 13, which conditionally imports "fmt"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haaa got you my bad :-)

@gbotrel gbotrel merged commit a7db149 into develop Dec 15, 2021
@gbotrel gbotrel deleted the field-intX-support branch December 15, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants