clean: replace modulus generated by constants, add zero-alloc SetRandom #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gbotrel
commented
May 25, 2022
gbotrel
commented
- clean: remove unused fuzz test files
- refactor: remove Add Sub Double x86 asm impl
- refactor: remove neg x86 impl
- fix: no carry field generation path
- docs: clean up and cosmetics
- fix: fix previous commit
- docs: cosmetics changes
- style: simplyfing inverse in field element
- style: cosmetics changes in field element
- fix: ensure SetInterface(nil) doesn't panic
- test: added IsUint64 test in field element
- feat: use crypto/rand.Int for field.SetRandom
- fix: remove dead code
- test: use SetRandom instead of rand.read
- style: cosmetics
- build: restore golangci config
- feat: added zero alloc SetRandom and replace hardcoded modulus words with constants
- fix: correct endianess in SetRandom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.