-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unifying Hash To Curve code generation #209
Conversation
I haven't added parameters for some of the other curves in there yet. Will do that after another PR simplifying SSWU code generation, removing generation-time parameter computation, after which I can delete all field arithmetic logic. Currently, if we try to develop field config classes for degree 4 extensions, we would have to implement arithmetic in towers as well which I would like to avoid. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! we can merge this.
Also the new svdw is 9% faster for BN254 G1 (and 4% for G2).
Nice! It's probably because of how the precomputed values are loaded. |
Unifying code generation for SvdW and SSWU