Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedersen hash on stark-curve #327

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Pedersen hash on stark-curve #327

merged 4 commits into from
Feb 3, 2023

Conversation

yelhousni
Copy link
Collaborator

@yelhousni yelhousni mentioned this pull request Feb 3, 2023
Closed
yelhousni referenced this pull request Feb 3, 2023
@yelhousni
refactor(ecdsa): remove Params struct
eb8bce9
@yelhousni
Copy link
Collaborator Author

Some optimisations in mind:

  • the scalar multiplication by highPart can be fully or partially hardcoded, because the points (p1 and p3) are constants and the scalar is always 4 bits.
  • instead of recovering the x coordinate in Pedersen() you can recover it in PedersenArray() and mutualise all the inverses 1/zi

Will merge this now.

@yelhousni yelhousni merged commit e77b091 into develop Feb 3, 2023
@yelhousni yelhousni deleted the pedersen-hash branch February 3, 2023 17:20
@yelhousni yelhousni mentioned this pull request Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel gbotrel approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yelhousni @gbotrel @anshulforyou