Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalarMul works incorrectly for twisted edwards bn254 #57

Closed
SherLzp opened this issue May 30, 2021 · 0 comments · Fixed by #70
Closed

ScalarMul works incorrectly for twisted edwards bn254 #57

SherLzp opened this issue May 30, 2021 · 0 comments · Fixed by #70

Comments

@SherLzp
Copy link
Contributor

SherLzp commented May 30, 2021 •
edited
Loading

Just try the following test:

A := new(Point).ScalarMul(Base, big.NewInt(5))
B := new(Point).ScalarMul(Base, big.NewInt(-5))
C := new(Point).Add(A,B)

D := new(Point).ScalarMul(Base, Order)

The outputs A,B are the same result. And D is not (0,1). The computation result is different from: iden3-crypto. And I'm wondering that could I implement BulletProofs based on twisted edwards bn254?
@SherLzp SherLzp changed the title ScalarMul works incorrectly ScalarMul works incorrectly for twisted edwards bn254 May 30, 2021
ThomasPiellard added a commit that referenced this issue May 31, 2021
@ThomasPiellard
fix(twisted Edwards): fixed Neg(), and fixes #57
04c779b
@gbotrel gbotrel mentioned this issue Aug 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.5.0 Consensys/gnark-crypto
2 participants
@SherLzp @ThomasPiellard