Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add secp256k1 curve #277

Merged
merged 9 commits into from
Dec 21, 2022
Merged

[feat] Add secp256k1 curve #277

merged 9 commits into from
Dec 21, 2022

Conversation

yelhousni
Copy link
Collaborator

draft PR to track adding secp256k1 curve to gnark-crypto and ECDSA

@yelhousni yelhousni marked this pull request as draft December 8, 2022 16:26
@yelhousni yelhousni self-assigned this Dec 8, 2022
@yelhousni yelhousni marked this pull request as ready for review December 13, 2022 16:12
@yelhousni
Copy link
Collaborator Author

TODO:

  • optimize field arithmetic (no spare bit)
  • ECDSA (separate PR)
  • secq256k1? (maybe, separate PR)

@yelhousni
Copy link
Collaborator Author

MSM track on branch secp256k1/MSM. We can merge this.

@yelhousni yelhousni merged commit adf9aa3 into develop Dec 21, 2022
@yelhousni yelhousni deleted the feat/secp256k1 branch January 4, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevaundray kevaundray kevaundray left review comments

@gbotrel gbotrel gbotrel approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees

@yelhousni yelhousni

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yelhousni @gbotrel @kevaundray