Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: do not export endomorphisms + Double in affine #382

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

yelhousni
Copy link
Collaborator

we don't need to export endomorphisms as we don't use them in gnark hints anymore. We do subgroup check directly in the circuit.

@yelhousni yelhousni requested a review from ivokub April 17, 2023 18:03
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yelhousni yelhousni merged commit 330c1cb into develop Apr 18, 2023
5 checks passed
@yelhousni yelhousni deleted the refactor/not-export-endo branch July 5, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants