Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma directive should support any name and value #22

Closed
federicobond opened this issue Nov 11, 2016 · 0 comments
Closed

Pragma directive should support any name and value #22

federicobond opened this issue Nov 11, 2016 · 0 comments

Comments

@federicobond
Copy link
Contributor

The Solidity pragma directive was designed to support any identifier as name and expression as value, for backwards compatibility.

We should generalize it and return a PragmaStatement with name and value, not one that is restricted to solidity and a parsed version number.

If we are going to make this change, I would also suggest renaming it to PragmaDirective, which is a more descriptive name and in line with the official grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant