Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get-forkchoice-snapshot debug command to handle no snapshot #3598

Merged
merged 1 commit into from Feb 15, 2021
Merged

Update get-forkchoice-snapshot debug command to handle no snapshot #3598

merged 1 commit into from Feb 15, 2021

Conversation

ajsutton
Copy link
Contributor

PR Description

We no longer store separate protoarray snapshots because we rebuild them from the block data. So update the get-forkchoice-snapshot command to handle not having a snapshot and just reporting the votes if that's the case.

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone
rolfyone approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 66751f2 into Consensys:master Feb 15, 2021
@ajsutton ajsutton deleted the update-forkchoice-debug-command branch February 15, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajsutton @rolfyone