Cache public key group membership status #4075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Group membership checks for elliptic curve points (public keys and signatures) are very expensive and we want to do them as little as possible, ideally checking each point we use in verification exactly once.
When aggregating public keys using Blst's
blst.P1.aggregate()
method, the keys' group membership is always checked, even if it was checked previously. With this PR, we lazily check a public key's group membership and cache the result. We can then avoid the repeated group membership checks by usingblst.P1.add()
instead ofaggregate()
.Remarks:
BLSPublicKey
objects are well-cached and not created anew: we lose the cached group check status in that case.core_verify()
still checks group membership of the aggregated key. Not a lot we can do about that.Fixed Issue(s)
Closes #4032
Documentation
documentation
label to this PR if updates are required.Changelog