This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Reinstate false positive filtering of Mythril's dynamic array #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbanmp
reviewed
Mar 5, 2019
lib/srcmap.js
Outdated
| @@ -43,7 +43,7 @@ module.exports = { | |||
| /** | |||
| * Takes a bytecode hexstring and returns a map indexed by offset | |||
| * that give the instruction number for that offset. | |||
| * | |||
| *ok | |||
There was a problem hiding this comment.
No doubt that was meant for some discord user -- I have too many Emacs windows.
Should be fixed in 6dc1164
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nbanmp - This code got accidentally orphaned here and then got stale as a result of MythX changes. For the last 6 months or so it has been and is slated to go into MythX.
When it eventually does, it will finally get removed altogether. However for exposition purposes in say a Medium article, it is useful to have working as it shows an example of what kinds of synergy MythX is capable of by mixing tool output with static information.
@daniyarchambylov I spent some time trying to figure out how to reinstate the 3 isIgnorable tests, and ran out of patience. In tracing there seems to be something weird in the way the AST traversal was working with I guess with one of the mocking/stubbing functions.
Separate from that, I found that by changing one interface to add a paramter, 15 places in
test_issueslint.jsneeded to be changed. This means that the tests are not DRY (do not repeat yourself). I started pulling out the creation routine in to a single function so that this wouldn't happen again. But this is not complete, There is a lot of other duplicated code is mock and stub setup, that now fails as a result of this.I'd greatly appreciate it if you would fix up the isIgnorable test and DRY the code so that if interfaces change again, we don't have massive changes to the tests (even if it is merely a single search and replace done 15 times). Thanks.