Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

If debug mode, MythX info log should not be ignored #131

Merged
merged 4 commits into from Mar 16, 2019

Conversation

tagomaru
Copy link
Collaborator

@rocky
Sorry, but I was reviewing #128 still.

According to the comment Ignore logs with log.level "info" unless the "debug" flag has been set. on the code, the condition may not be correct.

@tagomaru tagomaru requested a review from rocky March 16, 2019 13:10
Copy link
Contributor

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, yes that was my mistake. Thanks for finding/fixing.

how do you feel about DRY'ing the testing code such as c523856 ?

Copy link
Collaborator Author

@tagomaru tagomaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i send new one.
level should be log

@rocky rocky merged commit dc7a1bc into master Mar 16, 2019
@nbanmp nbanmp deleted the info-should-be-prited-if-debug branch June 12, 2019 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants