Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk retrieval of AWS key signing keys for Eth2 #499

Closed
jframe opened this issue Jan 27, 2022 · 1 comment
Closed

Bulk retrieval of AWS key signing keys for Eth2 #499

jframe opened this issue Jan 27, 2022 · 1 comment
Assignees
@usmansaleem
Labels
TeamGroot Under active development by TeamGroot @PegaSys

Comments

@jframe
Copy link
Contributor

jframe commented Jan 27, 2022 •
edited by siladu

Bulk retrieval of AWS key signing keys for Eth2.
This is required for performance reasons.

Tasks

  • Performance test, e.g. load ~2000 on startup in ~1min (c.f. Azure load test)
  • Integration Tests (can't do units)
  • Implement AWS variant of signers AzureKeyVault.mapSecrets() in signers
  • Follow Azure's cli options config pattern (config may be refactored in another story)

Notes

  • Follow Azure's optimisation patterns, e.g. paging, same (already authenticated) vault instance connection, caching
@jframe jframe added the TeamGroot Under active development by TeamGroot @PegaSys label Jan 27, 2022
@georgep9 georgep9 mentioned this issue Apr 3, 2022
Merged
@georgep9 georgep9 mentioned this issue Apr 27, 2022
Closed
6 tasks
georgep9 added a commit to Consensys/signers that referenced this issue May 4, 2022
@georgep9
Support for AWS bulk loading (#141)
f80804a 
Implemented mapper function similar to Azure to support bulk loading of secrets from AWS Secrets Manager.

Supports issue Consensys/web3signer#499
@georgep9 georgep9 mentioned this issue May 4, 2022
Merged
@georgep9 georgep9 mentioned this issue May 17, 2022
Merged
@georgep9 georgep9 mentioned this issue May 24, 2022
Closed
@usmansaleem usmansaleem assigned usmansaleem and unassigned georgep9 May 26, 2022
@usmansaleem usmansaleem mentioned this issue Jun 7, 2022
Merged
2 tasks
@usmansaleem
Copy link
Contributor

10,000 keys 2vCPU (t2.medium)
Loading time (seconds) vs Keys

10,000 keys 4vCPU (t2.xlarge)
Loading Time (seconds) vs Keys(1)

@usmansaleem usmansaleem added the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 17, 2022
@alexandratran alexandratran mentioned this issue Jun 20, 2022
Closed
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usmansaleem usmansaleem

Labels
TeamGroot Under active development by TeamGroot @PegaSys
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bulk retrieval of AWS key signing keys for Eth2 georgep9/web3signer
4 participants
@usmansaleem @jframe @alexandratran @georgep9