Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"YAMLException: The incoming YAML document exceeds the limit: 3145728 code points." #719

Closed
gg718 opened this issue Feb 22, 2023 · 1 comment
Assignees
Labels
P3 Medium TeamGroot Under active development by TeamGroot @PegaSys

Comments

@gg718
Copy link

gg718 commented Feb 22, 2023

While testing PR #692, I came across the following issue with files >3MB:

Error parsing signing metadata file /tmp/test.yaml: YAMLException: The incoming YAML document exceeds the limit: 3145728 code points.

Is there a reason for this limit, or can it be increased?

Ping @usmansaleem

@jframe jframe added the TeamGroot Under active development by TeamGroot @PegaSys label Feb 22, 2023
@usmansaleem
Copy link
Contributor

Hi @gg718, this "limitation" was not intended and got introduced due to underlying SnakeYaml implementation (1.32) which is used by Jackon dataformat libraries. See https://github.com/FasterXML/jackson-dataformats-text/tree/2.15/yaml#maximum-input-yaml-document-size-3-mb

We will make some modifications in Web3Signer to set the default value to 1GB and also make it configureable using a cli option as well.

@usmansaleem usmansaleem added the P2 High label Feb 23, 2023
@jframe jframe added P3 Medium and removed P2 High labels Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Medium TeamGroot Under active development by TeamGroot @PegaSys
Projects
None yet
Development

No branches or pull requests

3 participants