Upgrade signers to 1.0.19 #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes vertx upgrade and azure key vault upgrade with breaking change to SECP256K1 curve.
Don't rely on deriving the public key from private key when verifying signature (because Azure private key is not known)
usmansaleem
reviewed
Sep 23, 2021
usmansaleem
reviewed
Sep 23, 2021
...nce-tests/src/test/java/tech/pegasys/web3signer/tests/signing/SecpSigningAcceptanceTest.java
Outdated
Show resolved
Hide resolved
usmansaleem
reviewed
Sep 23, 2021
usmansaleem
approved these changes
Sep 23, 2021
jframe
approved these changes
Sep 23, 2021
Update changelog with suggestion Upgrade to signers 1.0.19 and add changelog for that too Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes vertx upgrade and azure key vault upgrade with breaking change to SECP256K1 curve.