Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invariant that Fund's totalRevenue never decreases #17

Open
ethers opened this issue Jul 24, 2016 · 3 comments
Open

Invariant that Fund's totalRevenue never decreases #17

ethers opened this issue Jul 24, 2016 · 3 comments

Comments

@ethers
Copy link
Collaborator

ethers commented Jul 24, 2016

Document the invariant that Fund's totalRevenue never decreases. (otherwise line 64 totalRevenue - revenueAtTimeOfWithdraw[forAddress], becomes a negative number, leading to value being really big, and thus block all withdrawals)

9358448#commitcomment-18370130
@Georgi87
Copy link
Contributor

Georgi87 commented Aug 2, 2016

How would you implement this invariant?

@Georgi87
Copy link
Contributor

Georgi87 commented Aug 2, 2016

Maybe we should wait for ethereum/solidity#686

@ethers
Copy link
Collaborator Author

ethers commented Aug 12, 2016

Yes, enforcing this invariant may cost more than its benefits; so maybe we just document/comment it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Georgi87 @ethers