Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider documenting important invariants #27

Open
ethers opened this issue Jul 26, 2016 · 0 comments
Open

Consider documenting important invariants #27

ethers opened this issue Jul 26, 2016 · 0 comments

Comments

@ethers
Copy link
Collaborator

ethers commented Jul 26, 2016

For example, totalRevenue

9358448#commitcomment-18370130

document the invariant that this never decreases. (otherwise line 64 totalRevenue - revenueAtTimeOfWithdraw[forAddress], becomes a negative number, leading to value being really big, and thus block all withdrawals)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethers