Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mul_assign not implemented #163

Open
DavePearce opened this issue May 27, 2024 · 1 comment
Open

mul_assign not implemented #163

DavePearce opened this issue May 27, 2024 · 1 comment

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented May 27, 2024

In the full traces being checked using the -N switch, there is a panic arising:

panicked at src/column.rs:132:53:

This points to this piece of code:

pub(crate) fn mul_assign(&mut self, other: &Value) {
        match (self, other) {
            (Value::BigInt(ref mut i1), Value::BigInt(ref i2)) => *i1 *= i2,
            (Value::BigInt(x), Value::Native(y)) => todo!("{} *= {}", x, y), // <---- HERE
            (Value::BigInt(_), Value::ExoNative(_)) => todo!(),
            (Value::Native(_), Value::BigInt(_)) => todo!(),
            (Value::Native(ref mut f1), Value::Native(ref f2)) => f1.mul_assign(f2),
            (Value::Native(_), Value::ExoNative(_)) => todo!(),
            (Value::ExoNative(_), Value::BigInt(_)) => todo!(),
            (Value::ExoNative(_), Value::Native(_)) => todo!(),
            (Value::ExoNative(_), Value::ExoNative(_)) => todo!(),
        }
    }

Relevant part of the backtrace:

  3: corset::column::Value::mul_assign
             at ./src/column.rs:134:53
   4: corset::check::check_lookup::pseudo_rlc
             at ./src/check.rs:344:13
   5: corset::check::check_lookup
             at ./src/check.rs:389:37
   6: corset::check::check::{{closure}}
             at ./src/check.rs:531:41

So, that looks like a Value::BigInt is creeping in somehow without being converted to a Value::Native.

@DavePearce
Copy link
Collaborator Author

DavePearce commented May 31, 2024

There is some interplay with expansion here. For example, running with -N / -eN / -eeN gives the above whilst -eeeN / -eeeeN does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant