Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VKK parameter to marshall logic of BN254 mpcsetup phase2Evaluations #1137

Closed

Conversation

irfanbozkurt
Copy link

@irfanbozkurt irfanbozkurt commented May 21, 2024

Description

Fixes #1136

vkey has a parameter "G1.K" that directly comes from the "G1.VKK" parameter of a Phase2Evaluations. However, Phase2Evaluations's marshalling code lacks this parameter, and this causes vkey to have "G1.K" as an empty list.

Eventually, a proof generated by outputted pkey can't be verified with the outputted vkey.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Simply conduct a multi-party phase2 ceremony locally. At the end of each step (initialize, contribute, verify), save the created artifacts into files.

Finally, call ExtractKeys with the phase2Evaluations that you read from fs and you'll realize that the created vKey has its "G1.K" parameter as an empty list.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@irfanbozkurt irfanbozkurt marked this pull request as draft May 23, 2024 09:11
@ewoolsey

This comment was marked as outdated.

@irfanbozkurt irfanbozkurt closed this by deleting the head repository Jun 3, 2024
@ewoolsey
Copy link

ewoolsey commented Jun 3, 2024

@irfanbozkurt did you mean to delete this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: BN254 mpcsetup "phase2Evaluations" file not encoded properly
3 participants