Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make library methods not static #6

Open
StefanBratanov opened this issue Dec 7, 2022 · 0 comments
Open

Make library methods not static #6

StefanBratanov opened this issue Dec 7, 2022 · 0 comments
Labels
binding Requires changes in the java binding at https://github.com/ethereum/c-kzg-4844/

Comments

@StefanBratanov
Copy link
Contributor

Currently, there is a limitation to the library that all methods are static in the library. This means that if the class is used concurrently with two different trusted setups it won't work.

The JNI binding could be changed to store a trusted setup per jobject. C doesn't have a map data structure, so some sort of custom map could be created (binary tree could be a solution)
@StefanBratanov StefanBratanov added the binding Requires changes in the java binding at https://github.com/ethereum/c-kzg-4844/ label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binding Requires changes in the java binding at https://github.com/ethereum/c-kzg-4844/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StefanBratanov