Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Generate spillings.toml #719

Open
DavePearce opened this issue May 19, 2024 · 0 comments
Open

Automatically Generate spillings.toml #719

DavePearce opened this issue May 19, 2024 · 0 comments

Comments

@DavePearce
Copy link
Collaborator

DavePearce commented May 19, 2024

The corset tool has been updated to generate toml output for spilling information. Thus, it could in principle be used to automatically populate the spilling.toml file. This issue is to manage the integration. Currently, the output looks like this:

> corset debug -s --toml zkevm.bin
# Automatically generated via `corset debug -s --toml`
[spillings]
    SHF_RT =    0
   ROM_LEX =    1
       BIN =   15
       MMU =   10
  TXN_DATA =    7
   EC_DATA =   11
INSTRUCTION_DECODER =    0
       SHF =   15
       GAS =    1
RLP_TX_RCPT =    7
       MXP =    3
BLAKE_2_F_MODEXP_DATA =    0
      MMIO =    1
       HUB =    1
       EXT =    7
       MUL =    8
  LOG_DATA =    1
 HASH_DATA =    0
       MOD =    7
       ROM =    1
    BIN_RT =    0
       EXP =    5
   SHAKIRA =    4
       WCP =   15
  LOG_INFO =    5
       TRM =    7
  RLP_ADDR =    7
       EUC =    1
   RLP_TXN =    7
 HASH_INFO =    0
       ADD =    1
       STP =    4

However, it is worth noting some differences from the original file. For example, we have LOG_INFO above and PUB_LOG_INFO in the original file. Likewise, SHF_RT is listed above but was not present in the original file.

@powerslider Thoughts / comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant