Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate struct validation from JSON package #430

Open
darioAnongba opened this issue Dec 8, 2021 · 0 comments
Open

Separate struct validation from JSON package #430

darioAnongba opened this issue Dec 8, 2021 · 0 comments

Comments

@darioAnongba
Copy link
Contributor

Currently the json package used to marshal and unmarshal structs is tied to the validator package used to validate entities. Validation and json are unrelated to each other so these packages should be separated

Acceptance criteria

  • Remove validation from json package
  • Remove global validator using init. Instantiate a validator in components that need one and define their own custom validation functions in the component directly. See manifest reader in infra for an example
  • Split yaml and json packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant