Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add epoch in hash calculation for generate_seed - (Spec PR #552) #390

Closed
schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Closed

Add epoch in hash calculation for generate_seed - (Spec PR #552) #390

schroedingerscode opened this issue Feb 26, 2019 · 1 comment
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want the generate_seed function to hash the active index root as well as the epoch, so that the seed generation logic functions as per the Beacon Chain spec.

Acceptance Criteria

  • generate_seed function in BeaconStateUtil should hash the active index root as well as the epoch. See the linked PR.
  • generate_seed should be adequately tested.

Additional Information
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Feb 26, 2019
@schroedingerscode schroedingerscode changed the title Add epoch in hash calculation for generate_seed - (Spec PR #552) Add epoch in hash calculation for generate_seed - (Spec PR #552) Feb 26, 2019
@vitorpy vitorpy mentioned this issue Feb 26, 2019
Merged
@schroedingerscode schroedingerscode added the in progress 🚧 This issue or pull request is in progress label Feb 26, 2019
@schroedingerscode
Copy link
Contributor Author

Closed by #393.

@schroedingerscode schroedingerscode removed the in progress 🚧 This issue or pull request is in progress label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@schroedingerscode