Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RANDAO reveal verification to 0.4 spec #446

Closed
benjaminion opened this issue Mar 9, 2019 · 1 comment
Closed

Update RANDAO reveal verification to 0.4 spec #446

benjaminion opened this issue Mar 9, 2019 · 1 comment
Assignees
@benjaminion
Labels
enhancement 🕵️‍♀️ New feature or request
Milestone
Beacon Chain v0.4...

Comments

@benjaminion
Copy link
Contributor

benjaminion commented Mar 9, 2019 •
edited
Loading

Description

As a developer, I want the randao process to verify the correct message so that clients can interoperate.

Acceptance Criteria

  • Verification of RANDAO matches the 0.4 spec by using hash_tree_root()
  • Other places where this matters are updated. This is probably
    • proposer randao reveals in MockP2PNetwork

Additional Information

The verify_and_update_randao() method in BlockProcessorUtil has the following method to compute the message to be verified:

    Bytes32 currentEpochBytes = Bytes32.leftPad(Bytes.ofUnsignedLong(currentEpoch.longValue()));

This has changed in the 0.4 spec and ought to be (the equivalent of) hash_tree_root(get_current_epoch(state))

The change was made in ethereum/consensus-specs#633 at this line
@benjaminion benjaminion added the enhancement 🕵️‍♀️ New feature or request label Mar 9, 2019
@benjaminion benjaminion added this to the Beacon Chain v0.4.0 Spec milestone Mar 9, 2019
@benjaminion benjaminion mentioned this issue Mar 9, 2019
Merged
@benjaminion benjaminion added the in progress 🚧 This issue or pull request is in progress label Mar 9, 2019
@benjaminion benjaminion self-assigned this Mar 9, 2019
@benjaminion
Copy link
Contributor Author

Closed by #447

@benjaminion benjaminion removed the in progress 🚧 This issue or pull request is in progress label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminion benjaminion

Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@benjaminion