Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Bitfields to Little Indian - (See Spec PR #575) #452

Closed
schroedingerscode opened this issue Mar 10, 2019 · 1 comment
Closed

Switch Bitfields to Little Indian - (See Spec PR #575) #452

schroedingerscode opened this issue Mar 10, 2019 · 1 comment
Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress
Milestone
Beacon Chain v0.4...

Comments

@schroedingerscode
Copy link
Contributor

Description

As a client implementor, I want bitfields to be little endian so that serialization of bitfields is compliant with the spec..

Acceptance Criteria

  • Bits in bitfield are stored in little endian byte order. This requires updating the
    get_bitfield_bit function.
  • Changes are adequately tested.

Additional Information

ethereum/consensus-specs#575
@schroedingerscode schroedingerscode added the enhancement 🕵️‍♀️ New feature or request label Mar 10, 2019
@schroedingerscode schroedingerscode added the in progress 🚧 This issue or pull request is in progress label Mar 10, 2019
@schroedingerscode schroedingerscode mentioned this issue Mar 11, 2019
Merged
@schroedingerscode
Copy link
Contributor Author

Resolved by #456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress
Projects
None yet
Milestone
Beacon Chain v0.4.0 Spec
Development

No branches or pull requests
1 participant
@schroedingerscode